build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... PS3, Line 17: .dq_map = { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... PS3, Line 17: .dq_map = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... PS3, Line 54: .read_type = READ_SMBUS, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... PS3, Line 54: .read_type = READ_SMBUS, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... PS3, Line 55: .spd_spec = {.spd_smbus_address[0] = 0xa0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/3/src/mainboard/google/deltau... PS3, Line 55: .spd_spec = {.spd_smbus_address[0] = 0xa0, please, no space before tabs