Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45787 )
Change subject: soc/intel: Move pch_enable_ioapic() to common code
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45787/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/45787/8/src/soc/intel/common/block/...
PS8, Line 298: lpc_pch_enable_ioapic
Why does this belong in the LPC driver?
Good question. I'm not sure where the IO APIC is located but I'd say it's more likely to be in the SA. However, even ye olde ICH7 says something about IOAPIC in southbridge code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a6afc1da50c8ee5bccda7f5671b516dc31fe023
Gerrit-Change-Number: 45787
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 14:18:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment