Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36840 )
Change subject: soc/intel/skylake: Clean up report_cpu_info() function
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36840/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36840/6//COMMIT_MSG@7
PS6, Line 7: Clean-up
The verb is spelled with a space: Clean up
Done
https://review.coreboot.org/c/coreboot/+/36840/6/src/cpu/x86/name/Makefile.i...
File src/cpu/x86/name/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36840/6/src/cpu/x86/name/Makefile.i...
PS6, Line 14: bootblock-y += name.c
This is not mentioned in the commit message. […]
This entry is required to make the fill_processor_name function available in bootblock. Updated the commit message to include this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf7b04edc3fce147f7856591ce7e5a0cd05f43fe
Gerrit-Change-Number: 36840
Gerrit-PatchSet: 7
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 15:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment