Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40338 )
Change subject: cpu/x86/acpi: Add function to get sleep number from Pm1 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a... PS1, Line 956: ACPI_S0
Instead of adding acpi_snum_from_pm1, can we just guarantee the values of these? […]
I made the same comment in a chromium CL. And add a comment that we want those explicit values.
https://review.coreboot.org/c/coreboot/+/40338/1/src/arch/x86/include/arch/a... PS1, Line 980: acpi_snum_from_pm1 This function is the exact same as acpi_sleep_from_pm1. If we want the reversal function we should we should add it accordingly. This function doesn't make sense in practice.