[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )

Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support
......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44632/19/src/mainboard/google/volte... 
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/44632/19/src/mainboard/google/volte... 
PS19, Line 134: chip drivers/intel/pmc_mux/conn
              : 						register "usb2_port_number" = "4"
              : 						register "usb3_port_number" = "2"
              : 						# SBU & HSL follow CC
              : 						device generic 1 on
              : 							probe DB_USB USB3_PASSIVE
              : 						end
              : 					end
based on previous review comments and schematics,
you will only have the USB3_ACTIVE configuration, right?
this needs to be removed - specially since you would have
one config with "probe" and one without for the same
port.