Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30990 )
Change subject: soc/apollolake: Generate DMAR table ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c File src/soc/intel/apollolake/acpi.c:
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@194 PS5, Line 194: in 32-bit space. */
The 32-bit limitation was only a workaround for the […]
Yes, now that you are saying it. So I need to read the complete 64 bit BAR and feed it into acpi_create_dmar_drhd(). Thanks for pointing that out, will change.
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@247 PS5, Line 247: !(MCHBAR32(DEFVTBAR) & VTBAR_ENABLED)) Because if GFX is diasbled (for some reason), VTD can still be active and we need to generate DMAR table. On the other hand, if VTD is disabled, no DMAR table should be generated even if GFX is enabled.
Also, please don't align with the `if` body. Use 4 spaces or 2 tabs.
Sorry, I do not see the issue here. Do you mean the alignment of the second line "!(MCHBAR32(DEFVTBAR) & VTBAR_ENABLED))"? There are two tabs right now.