10 Aug
2020
10 Aug
'20
6:15 p.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio/nuvoton: add a driver for nct668xd ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34948/9/src/superio/nuvoton/nct668x... File src/superio/nuvoton/nct668xd/superio.c:
https://review.coreboot.org/c/coreboot/+/34948/9/src/superio/nuvoton/nct668x... PS9, Line 25: #include <stdlib.h> not used
https://review.coreboot.org/c/coreboot/+/34948/9/src/superio/nuvoton/nct668x... PS9, Line 53: DEVICE_NOOP https://review.coreboot.org/c/coreboot/+/40206 ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78eca4ba2948c36a386306887f62773580f6e444
Gerrit-Change-Number: 34948
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Aug 2020 16:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment