Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38006 )
Change subject: usbdebug: Fix printk conversion
......................................................................
Patch Set 3:
Patch Set 2: Code-Review+1
Did the compiler warn about that? Does this also work with 64-bit compilation?
src/drivers/usb/ehci_debug.c:455:21: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'uintptr_t' {aka 'long unsigned int'} [-Werror=format=]
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dba96004de264fe1faf5485fb677a6b05123bba
Gerrit-Change-Number: 38006
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 Jan 2020 13:19:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment