Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph, HAOUAS Elyes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49539 )
Change subject: nb/intel/pineview/bootblock.c: include <arch/pci_io_cfg.h>
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Patchset:
PS3:
`pci_ops.h` intentionally provides header-file abstraction,
cf. CB:50231. Please stop making people running around in
circles and jumping through hoops, and start documenting
and discussing instead. Otherwise you risk that your
patches have a negative impact on average.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic82876433361e206be4c71d71bbc4b4e95213479
Gerrit-Change-Number: 49539
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 02 Feb 2021 15:57:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment