Attention is currently required from: Ruihai Zhou.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/11a3fe33_747ccb35 PS9, Line 135: const struct edp_bridge *bridge; `const struct edp_bridge *bridge = NULL;`
https://review.coreboot.org/c/coreboot/+/74048/comment/9f5a8e5e_42a31895 PS9, Line 153: assert(bridge->power_on); Just return -1 and move to line 145. ``` if (!bridge || !bridge->power_on) return -1; ```
In MIPI panel case, it is possible that we develop on a bare board without the MIPI panel then we will get a NULL handler(CB:74051). We should not assert here and block the booting if the MIPI panel does not exist.