Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
......................................................................
Patch Set 11:
hey Maxim, thanks for doing this! This is really useful. No wait. This is incredible.
I gave it a test on Cooperlake-SP CRB that has C62x. I used gpio_get() in loop to query all the pins.
Some came as 1 some are 0. I checked these 1s against schematics and they match pins that are pulled up. So it not a coincidence.
Unfortunately I do not have physical access to the board (that virus thing that everybody is talking about), so for real-world verification (e.g short a pin or blink a LED) we should try on something we have physical access to. I will try to arrange testing on TiogaPass
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idde32fdd53f1966e3ba6b7f5598ae8f51488d5a5
Gerrit-Change-Number: 39425
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Mar 2020 01:34:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment