[coreboot-gerrit] Change in coreboot[master]: lib/spd: respect spd memory part name override if present

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )

Change subject: lib/spd: respect spd memory part name override if present
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45459/12/src/lib/spd_bin.c 
File src/lib/spd_bin.c:

https://review.coreboot.org/c/coreboot/+/45459/12/src/lib/spd_bin.c@177 
PS12, Line 177: 		spd_name[name_len + 1] = 0;
> I had found the descrepancy while changing the code and considered adding a comment in code to point […]

I disagree on my specific comment. name_len +1 where name_len == DDR4_SPD_PART_LEN would be an out of bounds array access smashing the stack.

The point of my comment is that we should pass in ARRAY_SIZE(spd_name) into this function to correctly fill out the buffer. Your change will write to the array out of bounds.