Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39460 )
Change subject: tgl boards: Configure retimer Aux orientation
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4: Code-Review+2
Brandon, Can you clarify what the expected behavour on Port 0 (the MLB port will be). FWIU for that port we *do* want the SBU orientation to be done by the SOC (since that one doesn't have a retimer).
Does this patch accomplish that?
the GPIO settings are taking care of that for now...We might need to do some additional changes to this setting to have it fully correct, however with the current GPIO settings and this setting set to 0 the MLB port should be functioning correctly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29eb0513299126ad8d1ee11ded2c771f28ad13f3
Gerrit-Change-Number: 39460
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-CC: Prashant Malani
pmalani@chromium.org
Gerrit-Comment-Date: Mon, 23 Mar 2020 19:41:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment