Hello Patrick Rudolph, Matt DeVillier, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35921
to look at the new patch set (#3).
Change subject: mb/google/glados: port to FSP 2.0 ......................................................................
mb/google/glados: port to FSP 2.0
This patch is part of the patch series to drop support for FSP 1.1 in soc/intel/skylake.
The following modifications have been done to migrate the board(s) from FSP 1.1 to FSP 2.0:
- remove deprecated devicetree VR_RING domain (only 4 domains in FSP 2.0) - add AC/DC loadline values to devicetree (see TODO) - switch to using the FSP default VBT - set FSP board type to "mobile" - add FSP parameter DmiVc1 (see TODO)
TODO: - check loadline values again - loadline values in devicetree maybe can dropped again, as Maxim is working on adding missing loadline values in CB:35167 - find out why some boards set DmiVc1 - testing
Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/ramstage.c M src/mainboard/google/glados/romstage.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/glados/spd/spd_util.h D src/mainboard/google/glados/variants/asuka/data.vbt M src/mainboard/google/glados/variants/asuka/devicetree.cb M src/mainboard/google/glados/variants/asuka/variant.c M src/mainboard/google/glados/variants/baseboard/include/baseboard/variant.h D src/mainboard/google/glados/variants/caroline/data.vbt M src/mainboard/google/glados/variants/caroline/devicetree.cb M src/mainboard/google/glados/variants/caroline/variant.c D src/mainboard/google/glados/variants/cave/data.vbt M src/mainboard/google/glados/variants/cave/devicetree.cb M src/mainboard/google/glados/variants/cave/variant.c D src/mainboard/google/glados/variants/chell/data.vbt M src/mainboard/google/glados/variants/chell/devicetree.cb M src/mainboard/google/glados/variants/chell/variant.c M src/mainboard/google/glados/variants/glados/devicetree.cb M src/mainboard/google/glados/variants/glados/variant.c D src/mainboard/google/glados/variants/lars/data.vbt M src/mainboard/google/glados/variants/lars/devicetree.cb M src/mainboard/google/glados/variants/lars/variant.c D src/mainboard/google/glados/variants/sentry/data.vbt M src/mainboard/google/glados/variants/sentry/devicetree.cb M src/mainboard/google/glados/variants/sentry/variant.c 26 files changed, 269 insertions(+), 308 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/35921/3