Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37789 )
Change subject: acpigen: Add function to generate unicode names
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37789/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37789/1//COMMIT_MSG@9
PS1, Line 9: if
it
Done
https://review.coreboot.org/c/coreboot/+/37789/1//COMMIT_MSG@12
PS1, Line 12:
Can you comment on the implementation? When are ? characters used as substitute?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16992bd449e3a51f6a8875731cd45a9f43de5c8c
Gerrit-Change-Number: 37789
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Dec 2019 08:37:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment