build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45028 )
Change subject: common/block/pmc: Add a check to program the PchPmPwrCycDur ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45028/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/45028/1/src/soc/intel/common/block/... PS1, Line 229: uint8_t slp_a_min_assert, uint8_t pm_pwr_cyc_dur); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45028/1/src/soc/intel/common/block/... PS1, Line 229: uint8_t slp_a_min_assert, uint8_t pm_pwr_cyc_dur); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45028/1/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/45028/1/src/soc/intel/common/block/... PS1, Line 640: MinAssertDur50ms, MinAssertDur60us, MinAssertDur1ms, MinAssertDur50ms, MinAssertDur2s line over 96 characters
https://review.coreboot.org/c/coreboot/+/45028/1/src/soc/intel/common/block/... PS1, Line 686: get_min_assert_dur(slp_s4_min_assert, slp_s3_min_assert, slp_a_min_assert, pm_pwr_cyc_dur, line over 96 characters