Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34887 )
Change subject: mb/google/drallion: Add two variants - arcada_cml & sarien_cml
......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG@7
PS5, Line 7: Moffet:
What does "moffet" mean? Should this be "mb/google/drallion: Add arcada_cml & sarien_cml variants"?
Thanks, Done!
https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG@9
PS5, Line 9: EV
What is EV?
Ack, Will make sure not to use such words. Thanks, modified
https://review.coreboot.org/c/coreboot/+/34887/5//COMMIT_MSG@11
PS5, Line 11: EVT
Please, don't *EVER* mention the phase of a project. […]
Yes, will never repeat it. Thanks for correcting, Done.
https://review.coreboot.org/c/coreboot/+/34887/5/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34887/5/src/mainboard/google/dralli...
PS5, Line 230: arcada_ish.bin
Should this be called drallion_ish. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I766bdccb6f8b6924d6ae1abbe57035f4ff1f6f17
Gerrit-Change-Number: 34887
Gerrit-PatchSet: 7
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Aug 2019 22:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment