Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47205 )
Change subject: soc/amd/picasso: move MAX_CPUS setting from mainbaord to SoC Kconfig
......................................................................
Patch Set 1: Code-Review+2
I'd suggest against overriding the MAX_CPUS value from mainboards. I don't believe it provides any meaningful benefit and can cause problems in the long run.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53449b8fa73c5d13e6ea77bee6eed8896b7d3ec3
Gerrit-Change-Number: 47205
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 15:35:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment