Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38537 )
Change subject: libpayload/corebootfb: Keep local copy of framebuffer info
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38537/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/video/corebootfb.c:
https://review.coreboot.org/c/coreboot/+/38537/1/payloads/libpayload/drivers...
PS1, Line 234: if (FI->physical_address == 0)
Can we also remove FI-> now and just replace it with fbinfo. everywhere?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38537
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I852c4eb229dd0724114acb302ab2ed7164712b64
Gerrit-Change-Number: 38537
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Jan 2020 02:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment