Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 130: 1 Brandon - have you tried doing only the pad configuration in gpio.c and not setting this UPD? Instead set IomTypeCPortPadCfg[0-7] as 0. It looks like all that FSP is doing with this is configure the pad which we should be able to do in coreboot and not rely on FSP to do that.
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 219: NF6
doesn't the FSP automatically do this when […]
We should not rely on FSP to configure the pads for us.