Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34397 )
Change subject: mb/google/kohaku: Update DPTF parameters and TDP PL1/PL2 ......................................................................
Patch Set 7:
(5 comments)
Resolving all comments for submission.
https://review.coreboot.org/c/coreboot/+/34397/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34397/1//COMMIT_MSG@10 PS1, Line 10: The main perpose of this change is adjusting PL1, and we need further fine tuning later.
Done
Done
https://review.coreboot.org/c/coreboot/+/34397/1//COMMIT_MSG@10 PS1, Line 10: perpose
Done
Done
https://review.coreboot.org/c/coreboot/+/34397/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34397/4//COMMIT_MSG@9 PS4, Line 9: Update DPTF parameters and TDP PL1/PL2 values for kohaku. : : The main purpose of this change is adjusting PL1 and PL2, : and we need further fine tuning later.
What are you achieving with the update? […]
Done
https://review.coreboot.org/c/coreboot/+/34397/4//COMMIT_MSG@11 PS4, Line 11: The main purpose of this change is adjusting PL1 and PL2, : and we need further fine tuning later.
Please use the full textwidth.
Done
https://review.coreboot.org/c/coreboot/+/34397/6/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34397/6/src/mainboard/google/hatch/... PS6, Line 2: 8
I don't think so. We might use 8W PL1 in case of DPTF not working.
Done