Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37351 )
Change subject: AGESA,binaryPI: Fix stack location on entry to romstage ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37351/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37351/2//COMMIT_MSG@9 PS2, Line 9: setup Verb is spelled with a space: set up
https://review.coreboot.org/c/coreboot/+/37351/2//COMMIT_MSG@9 PS2, Line 9: For BSP CPU, setup stack location to match the symbol : from car.ld. For AP CPUs the stack is located outside : _car_region and is currently not accounted for in the : linker scripts. Allowed text width is 75 characters.
https://review.coreboot.org/c/coreboot/+/37351/2/src/drivers/amd/agesa/cache... File src/drivers/amd/agesa/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/37351/2/src/drivers/amd/agesa/cache... PS2, Line 41: Setup Set up