Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 3:
(3 comments)
I revert back to IOMMU interrupt configuration and deleted SMBus interrupt. I suggested myself by Linux kernel which seems to configure those devices such way.
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 95: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ : {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */
We do not have the VGA and Audio. […]
I deleted both entries
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 101: {NB_PCIE_PORT5_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* mPCIe slot 1: 02.5 */
This whitespace should be removed
Done
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mptable.c:
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 99: PCI_INT(0x0, 0x2, 0x0, 0x10); // mPCI
What is the reason of change here?
In the other comment, you mentioned that this function actually configure PCI device line, not function interrupt. Am I correct if there are 4 interrupt lines only, so there is no point in trying to configure line 0x4?