EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................
Patch Set 7:
Patch Set 7:
Patch Set 7:
Patch Set 6:
(4 comments)
One more thought here, for the consistent. We can remove the overwrite flag. And put all board default as enable PM if they don't want overwrite it. So we can keep the same behavior for all boards.
i want to handle it little different than what Furquan said but i will try to make use of existing code more and see how i can pass the existing GPIO_PM config from .c (via .cb from mainboard) to soc (gnvs) and make it available for runtime S0ix entry and exit
Oh, I mean we can get rid off gpio_override_pm flag and keep the config in devicetree.cb. Keep the default as MISCCFG_ENABLE_GPIO_PM_CONFIG if there is no intended to overwrite it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I120f8369b8d3cf7ac821332bdfa124f6ed0570e9
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 17 Dec 2019 11:23:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment