Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 15: Code-Review-1
(6 comments)
didn't check the named and offsets; found some other bugs though
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/gspi.c File util/inteltool/gspi.c:
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/gspi.c@205 PS15, Line 205: read16 read32
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/i2c.c File util/inteltool/i2c.c:
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/i2c.c@237 PS15, Line 237: read16 read32
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/thermal.c File util/inteltool/thermal.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/thermal.c@16... PS6, Line 163: *(
Done
not done yet
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/thermal.c File util/inteltool/thermal.c:
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/thermal.c@1... PS15, Line 176: *(thermalbase+thermal_registers[i].addr), use read32
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/thermal.c@1... PS15, Line 182: *(thermalbase+thermal_registers[i].addr), use read16
https://review.coreboot.org/c/coreboot/+/35189/15/util/inteltool/thermal.c@1... PS15, Line 188: *(thermalbase+thermal_registers[i].addr), use read8