Attention is currently required from: Shelley Chen, Taniya Das, Julius Werner, Sudheer Amrabadi.
Venkat Thogaru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot ......................................................................
Patch Set 6:
(3 comments)
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/af723466_8f002a97 PS4, Line 57: return false;
I would consider putting a die() or at least an assert(0) at the end of these functions because it s […]
Done. Update in latest patch 6
https://review.coreboot.org/c/coreboot/+/68384/comment/df7afee2_b1d79858 PS4, Line 67: printk(BIOS_INFO, "jtagid = %x\n", jtagid);
We already print the SKU ID that is constructed from this, we don't need to spam the log with so man […]
Done
https://review.coreboot.org/c/coreboot/+/68384/comment/cd38b0aa_e9b4bbd4 PS4, Line 70: printk(BIOS_INFO, "Pro_support: %d\n", chipinfolut[i].pro);
same
Done