Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email )
Change subject: mb/google/rex: introduce the mainboard.asl for all rex variants
......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS13:
how about a
File src/mainboard/google/rex/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/74886/comment/a8fd9266_7a5d4fd3 :
PS13, Line 40: /* Mainboard specific */
: #include "variant/acpi/mainboard.asl"
how about adding HID_SPI elan driver based on a Kconfig ?
that way, we don't need to keep mainboard.asl for each variant
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74886?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124
Gerrit-Change-Number: 74886
Gerrit-PatchSet: 13
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Sun, 04 Jun 2023 09:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment