Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45289 )
Change subject: mb/google/kukui: add support different ram table for Willow ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45289/2/src/mainboard/google/kukui/... PS2, Line 117: if (board_id() >= 6) : cached_ram_code += 0x10; : else : cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET; I would suggest to reverse the check because it can make sure the succeeding phase using the correct CONFIG_BOARD_SDRAM_TABLE_OFFSET value. So, please change to
if (board_id() >= 6) cached_ram_code += CONFIG_BOARD_SDRAM_TABLE_OFFSET;
and change the CONFIG_BOARD_SDRAM_TABLE_OFFSET in the Kconfig.