Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38748 )
Change subject: soc/intel/skylake: Control fixed io decode from device tree ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/38748/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38748/4//COMMIT_MSG@7 PS4, Line 7: device tree devicetree
https://review.coreboot.org/c/coreboot/+/38748/4//COMMIT_MSG@7 PS4, Line 7: io IO
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/lpc_lib.h:
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/common/block/... PS2, Line 75: the current
Why not, this is basically what it does. […]
Well, `lpc_set_fixed_io_ranges` sets the decode ranges according to its parameters, so it does not set "the current" decode ranges (rather, it sets new ones).
Maybe say: "Configure IO decode ranges"
https://review.coreboot.org/c/coreboot/+/38748/4/src/soc/intel/common/block/... File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/38748/4/src/soc/intel/common/block/... PS4, Line 45: lpc_set_fixed_io_ranges Can we rename this to `lpc_set_fixed_io_decode` for consistency? It touches the same register as `lpc_get_fixed_io_decode` above.
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/skylake/bootb... PS2, Line 132: config->lpc_ioe
That is what I initially did as well but this doesn't really work out well. […]
Ack