Attention is currently required from: Andrey Petrov, Ronak Kanabar, Subrata Banik.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80691?usp=email )
Change subject: drivers/intel/fsp2_0: Perform MP init post FSP-MultiPhase SI Init ......................................................................
Patch Set 6:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80691/comment/93aca95a_b8410ce4 : PS3, Line 7: FSP-S
i guess you mean to say `Add hooks to perform MP init post FSP-MultiPhase SI Init (if supported)`
Done
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/80691/comment/6adf4239_65bd451e : PS3, Line 158: /* Reinitialize CPUs if FSP-S has done MP Init */ : if (CONFIG(USE_INTEL_FSP_MP_INIT)) : do_mpinit_after_fsp();
if the goal is to skip do_mpinit_after_fsp() immediately after FSP-S API and wait till MultiPhaseSiI […]
Done
https://review.coreboot.org/c/coreboot/+/80691/comment/b0ef23d4_532540d3 : PS3, Line 159: goto fsp_init_done;
what is the point of calling `do_mpinit_after_fsp` when FSP itself is not compliant with FSP2. […]
Done
https://review.coreboot.org/c/coreboot/+/80691/comment/2296fa25_29a284b8 : PS3, Line 163: goto fsp_init_done;
same as before, assume FSP Multiphase Si Init itself is not enabled hence, why would we like to do d […]
Done
https://review.coreboot.org/c/coreboot/+/80691/comment/2a4de47a_90506f87 : PS3, Line 171: oto fsp_init_done;
again the same, if multi_phase_si_init itself is not implemented then what is the point of calling d […]
Done
https://review.coreboot.org/c/coreboot/+/80691/comment/e99d84fc_7543d39e : PS3, Line 204: USE_INTEL_FSP_MP_INIT
Since this option exist, the idea of this patch is to keep working for new platforms. […]
This is what we do.