Attention is currently required from: Furquan Shaikh. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52115 )
Change subject: mb/google/guybrush: PCIe GPIOs - enable enables, disable resets ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52115/comment/7c047b42_38eef4a4 PS1, Line 54: HIGH
Wouldn't you run into issues during the bringup if you are not ensuring that the timings are met? It […]
Not in my experience, no. Regardless, the timings are NOT a part of this patch and will not be handled as a part of this patch.
This is getting the setting to what they should have been before the bringup started, and that is it.
https://review.coreboot.org/c/coreboot/+/52115/comment/d4191ac8_7063693b PS1, Line 169: /* EN_PP3300_WLAN */
The early gpio init is getting moved from bootblock to psp_verstage. […]
Yes, I absolutely agree with you. I'll get to that when I'm working on the other bug.