Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47138 )
Change subject: soc/intel/common/acpi: fix Windows crash on S0ix-enabled boards
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l...
File src/soc/intel/common/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l...
PS1, Line 37: Return(Package(5) {0, Ones, Ones, Ones, Ones})
This looks very odd. But I guess you also tried to return an empty package?
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l...
PS1, Line 26: This function
What function?
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l...
PS1, Line 26: debugging
Why would there be constraints for debugging?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd08cbcb1dfcb8cbb23f4f4c902bf8c367c8e3ac
Gerrit-Change-Number: 47138
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 02 Nov 2020 22:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment