Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32903 )
Change subject: soc/intel/apollolake: Fix value stored to gnvs is never read
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32903/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32903/5//COMMIT_MSG@4
PS5, Line 4: zhaojohn
John Zhao (maybe update Gerrit?)
https://review.coreboot.org/#/c/32903/5//COMMIT_MSG@14
PS5, Line 14:
Please add a tag
Found-by: Clang static analyzer <version>
https://review.coreboot.org/#/c/32903/5//COMMIT_MSG@15
PS5, Line 15: Signed-off-by: John Zhao john.zhao@intel.com
Please move this below the Change-Id line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
Gerrit-Change-Number: 32903
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 May 2019 09:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment