Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )
Change subject: mb/google/dedede: Enable trackpad support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede...
PS4, Line 36: PAD_CFG_GPI_APIC
We would want to also enable wake on trackpad line.
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede...
PS4, Line 36: EDGE_SINGLE
Why EDGE_SINGLE? At pad, we just configure the trigger to be level to pass the signal as is to APIC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Mar 2020 17:31:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment