Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36921 )
Change subject: soc/mediatek/mt8183: TX RX window should not do fast K for High frequency ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@7 PS3, Line 7: soc/mediatek/mt8183: TX RX window should not do fast K for High frequency Please make it a statement of the change (imperative mood). Maybe:
soc/mediatek/mt8183: Skip fast K for high frequency for TX RX window
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@9 PS3, Line 9: frquency frequencies
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@10 PS3, Line 10: High high
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@10 PS3, Line 10: High frequency Like what values?
Is that limitation documented in a data sheet?
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@11 PS3, Line 11: Please quickly explain the implementation. Why do you lower some values for example.
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@14 PS3, Line 14: TEST=Boots correctly on Kukui Before it just hung or what?
https://review.coreboot.org/c/coreboot/+/36921/3//COMMIT_MSG@17 PS3, Line 17: Your Signed-off-by line is missing.