Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39964 )
Change subject: mb/google/cyan: convert to overridetree ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/d... File src/mainboard/google/cyan/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/d... PS1, Line 110: device pci 12.0 off end # 8086 0F16 - SD Port
Huh, TIL.
looks like it was an old pre-commit hook that generated that error. Updated the patchset :)
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/v... File src/mainboard/google/cyan/variants/edgar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/v... PS1, Line 4:
Because those were the original settings, basically. […]
I2C4 wasn't disabled in edgar's devicetree. Amended the commit msg for I2C1.