Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35795 )
Change subject: sb/intel/i82801gx: Move CIR init to a common place
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35795/3/src/mainboard/asus/p5gc-mx/...
File src/mainboard/asus/p5gc-mx/romstage.c:
https://review.coreboot.org/c/coreboot/+/35795/3/src/mainboard/asus/p5gc-mx/...
PS3, Line 151: 0x10030509;
this value is not the same
Hmm in all the logs I have this value is indeed programmed programmed.
Looking at serialICE logs on different targets 0x10030549 get programmed but 0x10030509 gets read back. I'll add a comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia10c050785170fc743f7aef918f4849dbdd6840e
Gerrit-Change-Number: 35795
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 04 Oct 2019 13:54:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment