Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36775 )
Change subject: mb/*/*{i440BX}: Enable console in bootblock ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36775/5/src/cpu/intel/slot_1/Kconfi... File src/cpu/intel/slot_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/36775/5/src/cpu/intel/slot_1/Kconfi... PS5, Line 44: hex how about
default 0x2000 if !BOOTBLOCK_CONSOLE
https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... File src/mainboard/asus/p2b-ls/early_init.c:
https://review.coreboot.org/c/coreboot/+/36775/5/src/mainboard/asus/p2b-ls/e... PS5, Line 46: #endif
Done
Why guard it at all?