Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41471 )
Change subject: soc/intel/broadwell: Mask lower 20 bits of TOLUD and TOLM in systemagent.asl
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41471/6/src/soc/intel/broadwell/acp...
File src/soc/intel/broadwell/acpi/systemagent.asl:
https://review.coreboot.org/c/coreboot/+/41471/6/src/soc/intel/broadwell/acp...
PS6, Line 156: If (Local0 == Local1) {
I don't think any chipset code reserves this region. I don't know why we
can't repurpose the ME space in this case. In most cases it is covered by
remapped DRAM maybe that is allowed but PCI resources are not? In any case,
we need to align C and ASL code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11b3ef8deda21930998471ab6e712da4c62f5b02
Gerrit-Change-Number: 41471
Gerrit-PatchSet: 6
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 12:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment