Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 4: ddr4 Volteer boards can use LPDDR4x or DDR4 memories. How do you plan to handle that?
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 9: , Fixed ID (optional) Just a note: This is not supported by LPDDR4x tool. We should add that support, but it is not present right now.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4 Dedede boards do not use DDR4 memory.