Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph, Karthik Ramasubramanian. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56005 )
Change subject: soc/intel/common/block/acpi: Add LPM requirements support to PEPD _DSM ......................................................................
Patch Set 1:
(6 comments)
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/56005/comment/513b3a10_68f6a590 PS1, Line 120: static void pep_s0ix_enum_functions(void *unused) In general, I don't see Kconfig SOC_INTEL_COMMON_BLOCK_ACPI_PEP_LPM_REQ been used to make pep.c generate or not generate LPM req feature. pep.c is compiled when CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_PEP is set.
https://review.coreboot.org/c/coreboot/+/56005/comment/de5060ab_15ba8c1a PS1, Line 143: PMC_IPC_SUBCMD_GEN_COMM_READ, Please see comments in pmc_ipc.h regarding of these two defines, we could just pass 0 for the 2nd argument.
https://review.coreboot.org/c/coreboot/+/56005/comment/3544fbc9_2805ea3c PS1, Line 166: pep_s0ix_collect_lpm_requirements, /* Return LPM requirements */ use #if for lpm req.
https://review.coreboot.org/c/coreboot/+/56005/comment/a840232a_9f2451e0 PS1, Line 173: DSM_UUID(PEP_S0IX_UUID, pep_s0ix, ARRAY_SIZE(pep_s0ix), NULL), use #if for lpm req.
File src/soc/intel/common/block/include/intelblocks/pmc_ipc.h:
https://review.coreboot.org/c/coreboot/+/56005/comment/dd4ef1fc_df394c41 PS1, Line 25: #define PMC_IPC_CMD_GENERAL_COMM 0xA0 Please rename to PMC_IPC_CMD_RD_PMC_REG.
https://review.coreboot.org/c/coreboot/+/56005/comment/182fcd93_130b83f9 PS1, Line 26: #define PMC_IPC_SUBCMD_GEN_COMM_READ 0x02 When Read PMC reg (0xa0) command is used, there is no subcmd/cmd ID needed. so this define is not required.