Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 board support ......................................................................
Patch Set 15:
(8 comments)
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... File Documentation/mainboard/libretrend/lt1000.md:
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... PS15, Line 34: Strongly advised to *It is* strongly advised to ...
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... PS15, Line 35: possessing the having an
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... PS15, Line 41: between the DIMM slots and the M.2 disk Right, I think I see it. 😄
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/acpi/mainboard.asl:
PS15: I don't think we need this file
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 14: #define SERIAL1_DEV PNP_DEV(0x2e, IT8786E_SP1) Where is SERIAL2_DEV ?
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 241: "THERMAL_MODE_DISABLED" Should fit on the previous line
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 254: LVDS backlight control?
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 31: #include "acpi/mainboard.asl" We don't need this