Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33060 )
Change subject: mb/google/hatch: Remove unused USB2 port5 from baseboard devicetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33060/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/33060/1/src/mainboard/google/hatch/variants/... PS1, Line 54: device pci 14.0 on : chip drivers/usb/acpi : register "desc" = ""Root Hub"" : register "type" = "UPC_TYPE_HUB" : device usb 0.0 on : chip drivers/usb/acpi : register "desc" = ""Left Type-C Port"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(1, 1)" : device usb 2.0 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-C Port 1"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 2.1 on end : end : chip drivers/usb/acpi : register "desc" = ""Left Type-A Port"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(1, 2)" : device usb 2.2 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-A Port 1"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(2, 2)" : device usb 2.3 on end : end : chip drivers/usb/acpi : register "desc" = ""Discrete bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" : device usb 2.4 on end : end : chip drivers/usb/acpi : register "desc" = ""WWAN"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.5 on end : end : chip drivers/usb/acpi : register "desc" = ""Camera"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.6 on end : end : chip drivers/usb/acpi : register "desc" = ""Integrated CnVi bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" : device usb 2.9 on end : end : chip drivers/usb/acpi : register "desc" = ""Left Type-C Port"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(1, 1)" : device usb 3.0 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-C Port 1"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 3.1 on end : end : chip drivers/usb/acpi : register "desc" = ""Left Type-A Port"" : register "type" = "UPC_TYPE_USB3_A" : register "group" = "ACPI_PLD_GROUP(1, 2)" : device usb 3.2 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-A Port 1"" : register "type" = "UPC_TYPE_USB3_A" : register "group" = "ACPI_PLD_GROUP(2, 2)" : device usb 3.3 on end : end : chip drivers/usb/acpi : register "desc" = ""WWAN"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 3.4 on end : end : end : end : end # USB xHCI
Not sure I understood, but the changes here are in override tree(specific to proto boards) and the b […]
What I meant is -- if all the devices are added to override tree, then you would end up duplicating almost all USB devices for different variants, which is not very helpful from code maintenance standpoint.