[coreboot-gerrit] Change in coreboot[master]: acpi/device: Add GPIO binding property for an array of GPIOs

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46056 )

Change subject: acpi/device: Add GPIO binding property for an array of GPIOs
......................................................................

acpi/device: Add GPIO binding property for an array of GPIOs

This change is required for use-cases like GPIO based I2C multiplexer
where more than one GPIOs are used as select lines.

BUG=b:169444894
TEST=Build and boot waddledee to OS. Ensure that the GPIO bindings for
an array of GPIOs are added to the ACPI table as follows:
Device (MUX0)
{
    ...
    Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
    {
        GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
                "\_SB.PCI0.GPIO", 0x00, ResourceConsumer, ,
                )
        {   // Pin list
            0x0125
        }
        GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
                "\_SB.PCI0.GPIO", 0x00, ResourceConsumer, ,
                )
        {   // Pin list
            0x0126
        }
    })
    Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
    {
        ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
                Package (0x01)
        {
            Package (0x02)
            {
                "mux-gpios",
                Package (0x08)
                {
                    _SB.PCI0.I2C3.MUX0,
                    Zero,
                    Zero,
                    Zero,
                    _SB.PCI0.I2C3.MUX0,
                    One,
                    Zero,
                    Zero
                }
            }
        }
    })
}

Change-Id: I7c6cc36b1bfca2d48c84f169e6b43fd4be8ba330
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/acpi/device.c
M src/include/acpi/acpi_device.h
2 files changed, 40 insertions(+), 23 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/46056/1

diff --git a/src/acpi/device.c b/src/acpi/device.c
index 450427d..06002c9 100644
--- a/src/acpi/device.c
+++ b/src/acpi/device.c
@@ -1019,33 +1019,45 @@
    return dp_array;
 }

+struct acpi_dp *acpi_dp_add_gpio_array(struct acpi_dp *dp, const char *name,
+				       const char *ref, int index, int pin,
+				       uint32_t gpio_count, int active_low)
+{
+	struct acpi_dp *gpio;
+	uint32_t i;
+
+	if (!dp || !gpio_count)
+		return NULL;
+
+	gpio = acpi_dp_new_table(name);
+	if (!gpio)
+		return NULL;
+
+	for (i = 0; i < gpio_count; i++) {
+		/* The device that has _CRS containing GpioIO()/GpioInt() */
+		acpi_dp_add_reference(gpio, NULL, ref);
+
+		/* Index of the GPIO resource in _CRS starting from zero */
+		acpi_dp_add_integer(gpio, NULL, index + i);
+
+		/* Pin in the GPIO resource, typically zero */
+		acpi_dp_add_integer(gpio, NULL, pin);
+
+		/* Set if pin is active low */
+		acpi_dp_add_integer(gpio, NULL, active_low);
+	}
+	acpi_dp_add_array(dp, gpio);
+
+	return gpio;
+
+}
+
+
 struct acpi_dp *acpi_dp_add_gpio(struct acpi_dp *dp, const char *name,
    			 const char *ref, int index, int pin,
    			 int active_low)
 {
-	if (!dp)
-		return NULL;
-
-	struct acpi_dp *gpio = acpi_dp_new_table(name);
-
-	if (!gpio)
-		return NULL;
-
-	/* The device that has _CRS containing GpioIO()/GpioInt() */
-	acpi_dp_add_reference(gpio, NULL, ref);
-
-	/* Index of the GPIO resource in _CRS starting from zero */
-	acpi_dp_add_integer(gpio, NULL, index);
-
-	/* Pin in the GPIO resource, typically zero */
-	acpi_dp_add_integer(gpio, NULL, pin);
-
-	/* Set if pin is active low */
-	acpi_dp_add_integer(gpio, NULL, active_low);
-
-	acpi_dp_add_array(dp, gpio);
-
-	return gpio;
+	return acpi_dp_add_gpio_array(dp, name, ref, index, pin, 1, active_low);
 }

/*
diff --git a/src/include/acpi/acpi_device.h b/src/include/acpi/acpi_device.h
index be13bd7..6fcdc2d 100644
--- a/src/include/acpi/acpi_device.h
+++ b/src/include/acpi/acpi_device.h
@@ -545,6 +545,11 @@
    			 const char *ref, int index, int pin,
    			 int active_low);

+/* Add a GPIO binding device property for array of GPIOs */
+struct acpi_dp *acpi_dp_add_gpio_array(struct acpi_dp *dp, const char *name,
+				       const char *ref, int index, int pin,
+				       uint32_t gpio_count, int active_low);
+
 /* Add a child table of Device Properties */
 struct acpi_dp *acpi_dp_add_child(struct acpi_dp *dp, const char *name,
    			  struct acpi_dp *child);