Attention is currently required from: Tarun Tuli, Henry Sun, Paul Menzel, Reka Norman, Nick Vaccaro, Shou-Chieh Hsu.
Lawrence Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69892 )
Change subject: mb/google/nissa/var/xivu: Fine-tune eMMC DLL
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69892/comment/6f688bb4_7b64538e
PS2, Line 12: TEST="Use the value to boot on Xivu successfully."
We still need the `TEST=` field, just remove the quote symbol. […]
Added "TEST" field.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69892
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa8338fd0faa0e01f42ee77dea135c7a241ed3be
Gerrit-Change-Number: 69892
Gerrit-PatchSet: 7
Gerrit-Owner: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 03:23:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Shou-Chieh Hsu
shouchieh@google.com
Comment-In-Reply-To: Lawrence Chang
lawrence.chang@intel.corp-partner.google.com
Gerrit-MessageType: comment