Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54812 )
Change subject: soc/intel/tigerlake: Return TBT PowerResource from PR0 and PR3 ......................................................................
soc/intel/tigerlake: Return TBT PowerResource from PR0 and PR3
TBT PowerResource _ON/_OFF methods are currently invoked by _PS0 and _PS3 respectively. It is defined for ACPI driver to call _ON and _OFF methods. This change drops the _PS0 and _PS3 call for _ON/_OFF and returns TBT PowerResource declaration in the _PR0 and _PR3, then ACPI driver will call the TBT PowerResource _ON and _OFF methods.
BUG=b:188891878 TEST=Traced both of TBT _ON and _OFF methods invocation and execution at run time. Verified TBT's power_state to be D3Cold.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I398b3f58ec89f98673cbbe633149d31188ec3351 Reviewed-on: https://review.coreboot.org/c/coreboot/+/54812 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/tigerlake/acpi/tcss_pcierp.asl 2 files changed, 20 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/acpi/tcss_dma.asl b/src/soc/intel/tigerlake/acpi/tcss_dma.asl index 085990d..273a71e 100644 --- a/src/soc/intel/tigerlake/acpi/tcss_dma.asl +++ b/src/soc/intel/tigerlake/acpi/tcss_dma.asl @@ -32,12 +32,20 @@
Method (_PR0) { - Return (Package() { _SB.PCI0.D3C }) + If (DUID == 0) { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT0 }) + } Else { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT1 }) + } }
Method (_PR3) { - Return (Package() { _SB.PCI0.D3C }) + If (DUID == 0) { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT0 }) + } Else { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT1 }) + } }
/* @@ -66,20 +74,10 @@
Method (_PS0, 0, Serialized) { - If (DUID == 0) { - _SB.PCI0.TBT0._ON() - } Else { - _SB.PCI0.TBT1._ON() - } }
Method (_PS3, 0, Serialized) { - If (DUID == 0) { - _SB.PCI0.TBT0._OFF() - } Else { - _SB.PCI0.TBT1._OFF() - } }
Method (_DSW, 3) diff --git a/src/soc/intel/tigerlake/acpi/tcss_pcierp.asl b/src/soc/intel/tigerlake/acpi/tcss_pcierp.asl index 0453f1c..847d87e 100644 --- a/src/soc/intel/tigerlake/acpi/tcss_pcierp.asl +++ b/src/soc/intel/tigerlake/acpi/tcss_pcierp.asl @@ -213,12 +213,20 @@
Method (_PR0) { - Return (Package() { _SB.PCI0.D3C }) + If ((TUID == 0) || (TUID == 1)) { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT0 }) + } Else { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT1 }) + } }
Method (_PR3) { - Return (Package() { _SB.PCI0.D3C }) + If ((TUID == 0) || (TUID == 1)) { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT0 }) + } Else { + Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT1 }) + } }
/*