build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35031 )
Change subject: soc/intel/skylake: Add Lewisburg PCH GPIOs support ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/bootb... PS2, Line 110: if (CONFIG(SKYLAKE_SOC_PCH_H)) || CONFIG(WELISBURG_SOC_PCH_H)) trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/gpio.... File src/soc/intel/skylake/gpio.c:
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/gpio.... PS2, Line 240: #else braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/gpio.... PS2, Line 243: # if CONFIG(SKYLAKE_SOC_PCH_H) braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/inclu... File src/soc/intel/skylake/include/soc/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/35031/2/src/soc/intel/skylake/inclu... PS2, Line 45: #define NUM_GPI_STATUS_REGS \ Macros with complex values should be enclosed in parentheses