Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39499 )
Change subject: mb/facebook/monolith: Configure COMB to 0x3e8
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39499/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39499/1//COMMIT_MSG@9
PS1, Line 9: The 2nd COM port is configured to the 0x2f8 default. Current software
Done
IMHO, the original sentence made more sense. Now it reads like
it's about the current hardware's default and not the COMB default.
But... doesn't matter much.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb462bad5f0594e0b5c8dea6e02cd42d58d999ab
Gerrit-Change-Number: 39499
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Mar 2020 09:46:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-MessageType: comment