Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33185 )
Change subject: libpayload/i8042/keyboard: Fix return value check for keyboard_cmd
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
LGTM, thanks. Nothing else in the function logs on error but I like having at least some msg there that helps make it clear when the keyboard isn't working.
https://review.coreboot.org/#/c/33185/2/payloads/libpayload/drivers/i8042/ke...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/#/c/33185/2/payloads/libpayload/drivers/i8042/ke...
PS2, Line 175: 0xfa
nit: using I8042_KBCMD_ACK here would help avoid the newly added #define from now being unused.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcadaae12e0a44e404a1d98c6deb633d97058203
Gerrit-Change-Number: 33185
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Jun 2019 04:22:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment