Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42897 )
Change subject: mb/google/volteer: Enable HotPlug on PCIe root port for the SD express
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42897/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42897/1/src/mainboard/google/voltee...
PS1, Line 91: PcieRpHotPlug
i should have noticed this last night - can you move this up 2 lines so it's […]
up 2 lines complete
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d427dd297567f06123119a670b5ed2e1f73701
Gerrit-Change-Number: 42897
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 11:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment